Repository navigation
Add mfem adapter - #323
Merged
Merged
Add mfem adapter#323
Conversation
Collaborator
Author
|
@hgangwar Did you want to open up a new PR with the updated/working version of the MFEM code? I can then close this PR. |
jacobmerson
marked this pull request as ready for review
October 9, 2026 15:37
Collaborator
Author
|
We need to Rebase this and get it merged in. |
Rather than pass data and layouts separately, we update the serializer to directly take the Field&. This does a better job of maintaining consistency with what data we are operating with. Also, it reduces the number of places we expose FieldData, which is really an internal implementation detail that we don't want readily exposed.
This resolves a bug in the deserialization where if the whole array was not communicated it would end up storing zeros in the the dofs that were not part of the communication. The current fix is quite expensive and points to the need for Set/Get functions that operate over subsets of the arrays.
This field adapter is not super general, but it does let us set up some MFEM heat transfer test cases for demonstration purposes. Currently it only supports scalars, MPI only (ParGridFunction), and linear H1 fields.
jacobmerson
force-pushed
the
add-mfem-adapter
branch
from
October 12, 2026 00:06
1a500f2 to
962b371
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.